refactor(multiple): eliminate usages of any type (batch 2)
#30613
Conversation
jamOne-
force-pushed
the
eliminate-any-2
branch
from
e20e9ee to
44be518
Compare
angular-robot
bot
added
the
area: build & ci
jamOne-
force-pushed
the
eliminate-any-2
branch
from
1a172ac to
41c329b
Compare
jamOne-
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
| @@ -235,7 +235,7 @@ export class DateFnsAdapter extends DateAdapter<Date, Locale> { | |||
| return super.deserialize(value); | |||
| } | |||
|
|
|||
| isDateInstance(obj: any): boolean { | |||
| isDateInstance(obj: unknown): obj is Date { | |||
There was a problem hiding this comment.
I think we should keep this as boolean even though date-fns says it's returning value is Date. Their implementation is clearly returning a boolean, not a Date-like object as it says here: https://github.com/date-fns/date-fns/blob/313b902b9a72c64501074db9bc2b9897d2db5140/src/isDate/index.ts#L33
In their original javascript implementation, they document that it's returning a boolean too`. I think this might have been a mistake when they changed to TypeScript? https://github.com/date-fns/date-fns/blob/6ba1acc644a444092c672d0d0af33fbe8e7b9481/src/isDate/index.js
There was a problem hiding this comment.
isDateInstance(obj: unknown): obj is Date indicates that isDateInstance is a "type guard". This in practice means that the function returns a boolean value, but also it narrows down the type of the passed argument (obj in this case).
If we had code like
function isFoo(x: unknown): x is Foo { ... }
const test: Foo | Bar = ...;
if (isFoo(test)) {
// test is of type Foo here
} else {
// test is of type Bar here
}https://www.typescriptlang.org/docs/handbook/advanced-types.html#user-defined-type-guards.
There was a problem hiding this comment.
Ohh okay interesting, thanks for explaining!
| @@ -263,7 +263,7 @@ export class LuxonDateAdapter extends DateAdapter<LuxonDateTime> { | |||
| return super.deserialize(value); | |||
| } | |||
|
|
|||
| isDateInstance(obj: any): boolean { | |||
| isDateInstance(obj: unknown): obj is LuxonDateTime { | |||
There was a problem hiding this comment.
same here - isn't this definitely a boolean?
anywithunknownor more specific typesFixsubmitted as a separate PR by andrewseguin (fix(youtube-player): use safevalues #30773)ban-script-src-assignmentsvulnerability inyoutube-player